Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex: Timetable Editor: Support Flex stop times allowing multiple stop times to have the same times #1008

Merged
merged 2 commits into from
Mar 4, 2024
Merged

Flex: Timetable Editor: Support Flex stop times allowing multiple stop times to have the same times #1008

merged 2 commits into from
Mar 4, 2024
+3 −2

Conversation

miles-grant-ibigroup
Copy link
Contributor

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

It seems the new flex spec allows you to have multiple stops and locations on the same row at the same time. This PR allows this for stops instead of just locations

@miles-grant-ibigroup miles-grant-ibigroup changed the base branch from dev to dev-flex February 16, 2024 19:38
binh-dam-ibigroup
binh-dam-ibigroup approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@binh-dam-ibigroup binh-dam-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

daniel-heppner-ibigroup
daniel-heppner-ibigroup approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@daniel-heppner-ibigroup daniel-heppner-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@miles-grant-ibigroup miles-grant-ibigroup merged commit aa2315c into dev-flex Mar 4, 2024
2 checks passed
@miles-grant-ibigroup miles-grant-ibigroup deleted the fix-flex-timetable-editor branch March 4, 2024 14:03
@miles-grant-ibigroup miles-grant-ibigroup restored the fix-flex-timetable-editor branch March 28, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-heppner-ibigroup daniel-heppner-ibigroup daniel-heppner-ibigroup approved these changes

@binh-dam-ibigroup binh-dam-ibigroup binh-dam-ibigroup approved these changes

Assignees

@miles-grant-ibigroup miles-grant-ibigroup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miles-grant-ibigroup @binh-dam-ibigroup @daniel-heppner-ibigroup @amy-corson-ibigroup